Only save /tmp/phpstan/resultCache.php to cache #3427
Conversation
The result cache is a huge win. CircleCI takes a very long time saving /tmp/phpstan/cache for some reason, and this cache doesn't affect the run time much anyway.
teohhanhui
force-pushed
the
fix/ci-phpstan-cache
branch
from
115fb90
to
4b8bcf4
Compare
|
Somehow the result cache is not being used. Investigating... |
|
/cc @ondrejmirtes perhaps you could lend a hand here... 🙏 Here you can see that But here phpstan is taking 14s, so it doesn't seem like the result cache is being used: Is there some kind of file modification checking that breaks with a CI workflow? |
|
Yes, in some CI systems the file modification time will not be preserved across runs. I plan to switch to file hashes instead but I need to inspect performance implications of that. |
|
Right now I verified the result cache works in Jenkins and TeamCity, but I'm not sure about GitLab CI and similar Docker-based systems. |
|
md5 should be very fast, even though it's prone to collisions... But good enough for this kind of use case. 😆 |
|
Merging as is to avoid the CircleCI issue with saving |
The result cache is a huge win.
CircleCI takes a very long time saving /tmp/phpstan/cache for some reason,
and this cache doesn't affect the run time much anyway.