Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update codecov/codecov-action to use tokenless upload #3429

Merged
merged 1 commit into from Mar 5, 2020
Merged

Update codecov/codecov-action to use tokenless upload #3429

merged 1 commit into from Mar 5, 2020

Conversation

teohhanhui
Copy link
Contributor

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tickets N/A
License MIT
Doc PR N/A

teohhanhui
teohhanhui commented Mar 5, 2020
View reviewed changes
.github/workflows/ci.yml
with:
name: phpunit-php${{ matrix.php }}
flags: phpunit
token: ${{ secrets.CODECOV_TOKEN }}
fail_ci_if_error: true
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We want the step to fail, but not the job to fail (continue-on-error: true below)

@teohhanhui
Copy link
Contributor Author

See Ocramius/PackageVersions#122 to understand why SymfonyInsight and Scrutinizer are broken (lol)

@teohhanhui
Copy link
Contributor Author

There may be some intermittent failures. Codecov's support for tokenless uploads from GitHub Actions is still very new.

@teohhanhui teohhanhui merged commit 914d9a6 into api-platform:2.5 Mar 5, 2020
@teohhanhui teohhanhui deleted the ci-codecov-tokenless branch March 5, 2020 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@teohhanhui