Fix purging HTTP cache for unreadable relations #3441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julienfalque
force-pushed
the
fix-http-purge-unreadable-relation
branch
2 times, most recently
from
3e82053
to
6773a99
Compare
julienfalque
force-pushed
the
fix-http-purge-unreadable-relation
branch
from
6773a99
to
f4f55a5
Compare
julienfalque
force-pushed
the
fix-http-purge-unreadable-relation
branch
from
f4f55a5
to
433f2a4
Compare
dunglas
approved these changes
Nov 2, 2020
alanpoulain
force-pushed
the
fix-http-purge-unreadable-relation
branch
from
433f2a4
to
a744e18
Compare
alanpoulain
force-pushed
the
fix-http-purge-unreadable-relation
branch
from
a744e18
to
307f0a1
Compare
|
Thank you @julienfalque. |
|
Thank you @alanpoulain and @dunglas. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When purging HTTP Cache Tags on Doctrine flush event, API Platform uses Doctrine mapping to determine the tags to purge. When doing so it assumes all mapped associations have a public accessor on the entity but sometimes this is not true and trying to access the value throws an exception.
I assume unreadable associations can be silently ignored as it means the associated entities don't appear in serialized responses which don't have the related tags anyway.