Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Allow objects without properties #3544

Merged
merged 4 commits into from May 12, 2020
Merged

Fix: Allow objects without properties #3544

merged 4 commits into from May 12, 2020

Conversation

OskarStark
Copy link
Contributor

@OskarStark OskarStark commented May 5, 2020 •
edited

Q A
Bug fix? yes
New feature? no
BC breaks? maybe ?
Deprecations? yes/no
Tickets refs #3445, refs #2563, refs #3343,
License MIT
Doc PR api-platform/docs#...

see #3445 (comment) for more information

@OskarStark OskarStark force-pushed the fix/allow-objects-without-properties branch 6 times, most recently from be6817f to d1d2781 Compare May 5, 2020 07:40
@OskarStark OskarStark force-pushed the fix/allow-objects-without-properties branch from d1d2781 to 05e515f Compare May 5, 2020 10:48
@OskarStark @localheinz
Refactor tests
5d93361 
Co-authored-by: Andreas Möller <am@localheinz.com>
localheinz
localheinz approved these changes May 5, 2020
View reviewed changes
Copy link
Contributor

@localheinz localheinz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@OskarStark OskarStark marked this pull request as ready for review May 5, 2020 11:51
@OskarStark
Copy link
Contributor Author

Not sure why two of the CI steps are failing 🤔

@dunglas
Copy link
Member

dunglas commented May 5, 2020

CI failures look unrelated with your PR. Something is probably broken in dev versions of Symfony and Doctrine.

@OskarStark
Copy link
Contributor Author

Any chance to get this merged and released?

@dunglas dunglas merged commit d5916f2 into api-platform:2.5 May 12, 2020
@dunglas
Copy link
Member

dunglas commented May 12, 2020

Thanks @OskarStark

@OskarStark OskarStark deleted the fix/allow-objects-without-properties branch May 12, 2020 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dunglas dunglas dunglas approved these changes

@localheinz localheinz localheinz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@OskarStark @dunglas @localheinz