Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#3676 - fixed subresource pagination support if primary resource has pagination disabled #3678

Merged
merged 1 commit into from Aug 27, 2020

Conversation

nightio
Copy link
Contributor

@nightio nightio commented Aug 17, 2020

Q A
Bug fix? yes - it fixes wrong behavior
New feature? no
BC breaks? possibly it can enable pagination (in documentation) in some specyfic cases
Deprecations? no
Tickets #3676
License MIT
Doc PR -

Now the decision of subresource pagination is based on subresource operation or if not set, on subresource resource. Previously was based on Primary resource get operation or Primary resource itself.

Copy link
Member

@dunglas dunglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a non-regression test please?

@dunglas dunglas merged commit ae350a9 into api-platform:2.5 Aug 27, 2020
@dunglas
Copy link
Member

dunglas commented Aug 27, 2020

Thanks @nightio, a non-regression test will still be very appreciated as an other PR :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants