Fix tests #3698
Merged
Fix tests #3698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dunglas
requested changes
Aug 31, 2020
| @@ -200,6 +201,6 @@ private function getReferenceType(string $resourceClass, ?int $referenceType): ? | |||
| $referenceType = $metadata->getAttribute('url_generation_strategy'); | |||
| } | |||
|
|
|||
| return $referenceType; | |||
| return null === $referenceType ? UrlGeneratorInterface::ABS_PATH : $referenceType; | |||
There was a problem hiding this comment.
Suggested change
| return null === $referenceType ? UrlGeneratorInterface::ABS_PATH : $referenceType; | |
| return $referenceType ?? UrlGeneratorInterface::ABS_PATH; |
| @@ -78,6 +79,11 @@ private function fieldsToAttributes(?string $resourceClass, ?ResourceMetadata $r | |||
| $fields = $info->getFieldSelection(PHP_INT_MAX); | |||
| } | |||
|
|
|||
| // On lowest symfony dependencies there's a bug in the name converter not accepting a string in the group ssee https://github.com/symfony/symfony/pull/34490 | |||
There was a problem hiding this comment.
Suggested change
| // On lowest symfony dependencies there's a bug in the name converter not accepting a string in the group ssee https://github.com/symfony/symfony/pull/34490 | |
| // On lowest symfony dependencies there's a bug in the name converter not accepting a string in the group see https://github.com/symfony/symfony/pull/34490 |
I suggest to require symfony/serializer >=4.3.9 instead.
| @@ -78,6 +79,11 @@ private function fieldsToAttributes(?string $resourceClass, ?ResourceMetadata $r | |||
| $fields = $info->getFieldSelection(PHP_INT_MAX); | |||
| } | |||
|
|
|||
| // On lowest symfony dependencies there's a bug in the name converter not accepting a string in the group ssee https://github.com/symfony/symfony/pull/34490 | |||
| if (isset($context[AbstractNormalizer::GROUPS]) && !\is_array($context[AbstractNormalizer::GROUPS])) { | |||
| $context[AbstractNormalizer::GROUPS] = [$context[AbstractNormalizer::GROUPS]]; | |||
There was a problem hiding this comment.
Could be (array) $context[AbstractNormalizer::GROUPS] too.
soyuka
force-pushed
the
fix-tests
branch
4 times, most recently
from
3eb83e5
to
e42ff50
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the tests: