Fix/cov #3702
Merged
Fix/cov #3702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
dunglas
commented
Sep 1, 2020
dunglas
commented
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tickets | fixes #... |
| License | MIT |
| Doc PR | n/a |
soyuka
force-pushed
the
fix/cov
branch
2 times, most recently
from
da79995
to
0cbfca5
Compare
soyuka
force-pushed
the
fix/cov
branch
4 times, most recently
from
2d3f778
to
b083283
Compare
dunglas
commented
Sep 5, 2020
.github/workflows/ci.yml
Outdated
| @@ -120,7 +120,7 @@ jobs: | |||
| composer update --no-progress --no-suggest --ansi | |||
| - name: Install PHPUnit | |||
| env: | |||
| SYMFONY_PHPUNIT_VERSION: '9.2' | |||
| SYMFONY_PHPUNIT_VERSION: '8.3' | |||
There was a problem hiding this comment.
It's better to run PHPStan with the latest versions of all deps.
| use PHPUnit\SebastianBergmann\Comparator\ComparisonFailure; | ||
| use SebastianBergmann\Comparator\ComparisonFailure as LegacyComparisonFailure; | ||
|
|
||
| if (!class_exists(ComparisonFailure::class)) { | ||
| class_alias(LegacyComparisonFailure::class, ComparisonFailure::class); | ||
| class_alias(LegacyComparisonFailure::class, 'PHPUnit\SebastianBergmann\Comparator\ComparisonFailure'); |
There was a problem hiding this comment.
You can keep using ::class even if the class doesn't exist.
There was a problem hiding this comment.
When using ::class, phpstan loads the class and fails because it doesn't find it.
| * | ||
| * @see https://github.com/sebastianbergmann/phpunit/issues/3494 | ||
| */ | ||
| final class ArraySubsetV9 extends Constraint |
There was a problem hiding this comment.
Mark these classes as internal maybe?
soyuka
force-pushed
the
fix/cov
branch
2 times, most recently
from
69f4d90
to
8c32dce
Compare
|
Thanks @soyuka! |
soyuka
added a commit
that referenced
this pull request
Sep 10, 2020
* fix prophecy trait (#3700) * fix prophecy trait * Support multiple phpunit version ArraySubset (#3702) * fix: restore coverage * Fix phpstan * Remove php-code-coverage dependency * Support multiple phpunit version ArraySubset Co-authored-by: soyuka <soyuka@users.noreply.github.com> Co-authored-by: Grégoire Hébert <gregoire@les-tilleuls.coop> Co-authored-by: Kévin Dunglas <dunglas@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.