Chunk headers to comply with Varnish max length #3843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julienfalque
force-pushed
the
fix-varnish-ban-header-length
branch
from
f0b78c1
to
a9f4138
Compare
|
thansk @julienfalque ! |
|
👍 to make this value configurable |
|
I'll work on that then :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR chunks the regex to send it in separate requests to avoid
400 Bad Requestresponses from Varnish when the maximum header length is exceeded. The default limit is 8000 for now since it's Varnish's default value, but that could be easily made configurable in another iteration (maybe for next minor release instead of 2.5?).