feat: add an ApiResource PHP 8 attribute #3851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dunglas
force-pushed
the
feat/php8-attributes
branch
3 times, most recently
from
5b37fc6
to
6a7d09d
Compare
dunglas
force-pushed
the
feat/php8-attributes
branch
from
6a7d09d
to
11dafa5
Compare
soyuka
reviewed
Nov 27, 2020
|
|
||
| foreach ($defaults as $option => $value) { | ||
| if (\in_array($option, $rootLevelOptions, true)) { | ||
| if (isset($publicProperties[$option])) { |
There was a problem hiding this comment.
Suggested change
| if (isset($publicProperties[$option])) { | |
| if ($publicProperties[$option] ?? false) { |
| @@ -598,7 +598,7 @@ private function addDefaultsSection(ArrayNodeDefinition $rootNode): void | |||
| return $normalizedDefaults; | |||
| }); | |||
|
|
|||
| foreach (ApiResource::CONFIGURABLE_DEFAULTS as $attribute) { | |||
| foreach (ApiResource::getConfigMetadata()[1] as $attribute => $_) { | |||
There was a problem hiding this comment.
[1] isn't so clear, I wish we could [, $configurableAttributes]; $configurableAttributes as ... :/
There was a problem hiding this comment.
We don't have something better for now.
dunglas
force-pushed
the
feat/php8-attributes
branch
from
b8dc849
to
8a5494d
Compare
soyuka
approved these changes
Nov 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHP 8 has been released today, let's celebrate!