Fix #3979 identifier chain not breaking after denormalizing #3985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
soyuka
commented
Jan 26, 2021
•
soyuka
commented
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tickets | fixes #3979 |
| License | MIT |
| Doc PR | na |
- lower priority of our identifier denormalizer for better DX
- break the chain of normalizers when an identifier transformer is found
soyuka
changed the title
soyuka
force-pushed
the
fix/3979
branch
2 times, most recently
from
fce8384
to
637d8da
Compare
soyuka
commented
Feb 1, 2021
| @@ -69,6 +69,7 @@ public function convert($data, string $class, array $context = []): array | |||
|
|
|||
| try { | |||
| $identifiers[$identifier] = $identifierTransformer->denormalize($value, $type); | |||
| break; | |||
| } catch (InvalidIdentifierException $e) { | |||
| throw new InvalidIdentifierException(sprintf('Identifier "%s" could not be denormalized.', $identifier), $e->getCode(), $e); | |||
| } | |||
cacahouwete
pushed a commit
to cacahouwete/core
that referenced
this pull request
Feb 8, 2021
…ng (api-platform#3985) * Lower the priority of our identifier denormalizers * Break on supported denormalizer * add test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.