Remove "oauth2" scheme from openapi security scheme #4073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
BeyerJC
commented
Feb 17, 2021
BeyerJC
commented
| Q | A |
|---|---|
| Bug fix? | yes |
| Deprecations? | no |
| Tickets | Fix #4071 |
| License | MIT |
BeyerJC
changed the title
alanpoulain
approved these changes
Feb 17, 2021
There was a problem hiding this comment.
The scheme key seems only to be used for Basic and Bearer indeed.
LGTM but @soyuka needs to confirm.
|
Please fix the unit tests too. |
BeyerJC
force-pushed
the
bugfix/remove-schema-in-oa-oauth2-security-scheme
branch
from
6a1d897
to
303fe13
Compare
soyuka
approved these changes
Feb 17, 2021
alanpoulain
reviewed
Feb 18, 2021
|
Thank you @WhiteRabbitDE. |
BeyerJC
deleted the
bugfix/remove-schema-in-oa-oauth2-security-scheme
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.