Revert using defaults.order as collection.order #4178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
guilliamxavier
commented
Mar 31, 2021
guilliamxavier
commented
| Q | A |
|---|---|
| Branch? | 2.6 |
| Bug fix? | yes |
| New feature? | no |
| Deprecations? | no |
| Tickets | Fix #4170 |
| License | MIT |
| Doc PR |
alanpoulain
reviewed
Mar 31, 2021
| @@ -58,7 +58,7 @@ public function applyToCollection(Builder $aggregationBuilder, string $resourceC | |||
| if (empty($defaultOrder)) { | |||
| $defaultOrder = $this->resourceMetadataFactory->create($resourceClass)->getAttribute('order'); | |||
| } | |||
| if (\is_array($defaultOrder)) { | |||
| if (null !== $defaultOrder) { | |||
There was a problem hiding this comment.
Isn't it better to keep is_array?
There was a problem hiding this comment.
I don't know, because:
- I consistently reverted all the changes of 3492922
- With
null !==(like it was originally) an incorrect config (e.g. a string value) gives you a Warning "Invalid argument supplied for foreach()" (then you fix your config 😉), withis_array()it is silently ignored (until you notice your config isn't applied? 😕) - See also Fix behaviour of "order" attribute #3472
But if you deem this part of the revert too risky, I can drop it (just say it)
There was a problem hiding this comment.
Not sure which one is the better 😅 Keep it like this, it's alright.
alanpoulain
approved these changes
Mar 31, 2021
|
Thanks 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.