Convert internal exception in UuidDenormalizer

[guilliamxavier]

Q	A
Branch?	2.6
Bug fix?	yes
New feature?	no
Deprecations?	no
Tickets	Fix #4189
License	MIT
Doc PR

[guilliamxavier]

For the exception, I hesitate between ApiPlatform\Core\Exception\DeserializationException and Symfony\Component\Serializer\Exception\NotNormalizableValueException 🤔

Also I guess this will need new test(s), but do you already agree on the principle?

[alanpoulain]

I don't think NotNormalizableValueException would lead to a 400 status code, isn't it (but it probably should)?

[guilliamxavier]

Yes it would, like all implementations of Symfony\Component\Serializer\Exception\ExceptionInterface. But I thought it may be better to use an ApiPlatform exception

[alanpoulain]

Oh yes you are right. Maybe using NotNormalizableValueException would be better then to be like the denormalizers in Symfony?

[soyuka]

Are you looking for https://github.com/api-platform/core/blob/5cb0508dd86c15fcbf8ef8b9c3012a2c445f4d6f/src/Exception/InvalidIdentifierException.php ?

[guilliamxavier]

@alanpoulain: OK I will use the Symfony one after all, thanks.

@soyuka: Thanks but I thought that InvalidIdentifierException (already thrown in ApiPlatform\Core\Bridge\RamseyUuid\Identifier\Normalizer\UuidNormalizer) was for e.g. GET /foos/invalid-uuid, while this (in ApiPlatform\Core\Bridge\RamseyUuid\Serializer\UuidDenormalizer) is for e.g. POST /foos {"uuid":"invalid-uuid"} (similar to the difference between ApiPlatform specific DateTimeIdentifierDenormalizer and Symfony generic DateTimeNormalizer)?

[soyuka]

My bad I thought this was related to identifier conversion not normalization, I'd be 👍 to transform this exception indeed. NotNormalizableValueException looks like the way to go here.

[alanpoulain]

Thank you @guilliamxavier.