fix(doctrine): denormalization of properties with embeds many that omit target document directive

features/mongodb/deserialize_embed_many_without_target_document.feature

@@ -0,0 +1,60 @@
+@mongodb
+Feature: Embed many without target document deserializable
+  In order to create and update resources
+  As a developer
+  I need to be able to deserialize data into objects with embed many that omit target document directive
+
+  @createSchema
+  Scenario: Post a resource with embedded data
+    When I add "Content-Type" header equal to "application/ld+json"
+    And I send a "POST" request to "/dummy_with_embed_many_omitting_target_documents" with body:
+    """
+    {
+      "embeddedDummies": [
+        {
+          "dummyName": "foo",
+          "dummyBoolean": true,
+          "dummyDate": "2020-01-01",
+          "dummyFloat": 0.1,
+          "dummyPrice": 10
+        },
+        {
+          "dummyName": "bar",
+          "dummyBoolean": false,
+          "dummyDate": "2021-01-01",
+          "dummyFloat": 0.2,
+          "dummyPrice": 20
+        }
+      ]
+    }
+    """
+    Then the response status code should be 201
+    And the response should be in JSON
+    And the header "Content-Type" should be equal to "application/ld+json; charset=utf-8"
+    And the JSON should be a superset of:
+    """
+    {
+      "@context": "/contexts/DummyWithEmbedManyOmittingTargetDocument",
+      "@id": "/dummy_with_embed_many_omitting_target_documents/1",
+      "@type": "DummyWithEmbedManyOmittingTargetDocument",
+      "id": 1,
+      "embeddedDummies": [
+        {
+          "@type": "EmbeddableDummy",
+          "dummyName": "foo",
+          "dummyBoolean": true,
+          "dummyDate": "2020-01-01T00:00:00+00:00",
+          "dummyFloat": 0.1,
+          "dummyPrice": 10
+        },
+        {
+          "@type": "EmbeddableDummy",
+          "dummyName": "bar",
+          "dummyBoolean": false,
+          "dummyDate": "2021-01-01T00:00:00+00:00",
+          "dummyFloat": 0.2,
+          "dummyPrice": 20
+        }
+      ]
+    }
+    """

src/Bridge/Doctrine/MongoDbOdm/PropertyInfo/DoctrineExtractor.php

@@ -63,8 +63,13 @@ public function getTypes($class, $property, array $context = [])
         }
 
         if ($metadata->hasAssociation($property)) {
+            /** @var ?string $class */
             $class = $metadata->getAssociationTargetClass($property);
 
+            if (null === $class) {
+                return null;
+            }
+
             if ($metadata->isSingleValuedAssociation($property)) {
                 $nullable = $metadata instanceof MongoDbClassMetadata && $metadata->isNullable($property);
 

tests/Bridge/Doctrine/MongoDbOdm/PropertyInfo/DoctrineExtractorTest.php

@@ -74,6 +74,7 @@ public function testTestGetPropertiesWithEmbedded(): void
                 'id',
                 'embedOne',
                 'embedMany',
+                'embedManyOmittingTargetDocument',
             ],
             $this->createExtractor()->getProperties(DoctrineWithEmbedded::class)
         );
@@ -197,6 +198,16 @@ public function testGeneratedValueNotWritable()
         $this->assertNull($extractor->isReadable(DoctrineGeneratedValue::class, 'foo'));
     }
 
+    public function testGetTypesWithEmbedManyOmittingTargetDocument(): void
+    {
+        $actualTypes = $this->createExtractor()->getTypes(
+            DoctrineWithEmbedded::class,
+            'embedManyOmittingTargetDocument'
+        );
+
+        self::assertNull($actualTypes);
+    }
+
     private function createExtractor(): DoctrineExtractor
     {
         $config = DoctrineMongoDbOdmSetup::createAnnotationMetadataConfiguration([__DIR__.\DIRECTORY_SEPARATOR.'Fixtures'], true);

tests/Bridge/Doctrine/MongoDbOdm/PropertyInfo/Fixtures/DoctrineWithEmbedded.php

@@ -39,4 +39,9 @@ class DoctrineWithEmbedded
      * @EmbedMany(targetDocument=DoctrineEmbeddable::class)
      */
     protected $embedMany;
+
+    /**
+     * @EmbedMany
+     */
+    protected $embedManyOmittingTargetDocument;
 }

tests/Fixtures/TestBundle/Document/DummyWithEmbedManyOmittingTargetDocument.php

@@ -0,0 +1,65 @@
+<?php
+
+/*
+ * This file is part of the API Platform project.
+ *
+ * (c) Kévin Dunglas <dunglas@gmail.com>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+declare(strict_types=1);
+
+namespace ApiPlatform\Core\Tests\Fixtures\TestBundle\Document;
+
+use ApiPlatform\Core\Annotation\ApiResource;
+use Doctrine\Common\Collections\ArrayCollection;
+use Doctrine\Common\Collections\Collection;
+use Doctrine\ODM\MongoDB\Mapping\Annotations as ODM;
+
+/**
+ * @ApiResource
+ * @ODM\Document
+ */
+class DummyWithEmbedManyOmittingTargetDocument
+{
+    /**
+     * @var int The id
+     *
+     * @ODM\Id(strategy="INCREMENT", type="int")
+     */
+    private $id;
+
+    /**
+     * @var EmbeddableDummy[]|Collection
+     *
+     * @ODM\EmbedMany
+     */
+    private $embeddedDummies;
+
+    public function __construct()
+    {
+        $this->embeddedDummies = new ArrayCollection();
+    }
+
+    public function getId()
+    {
+        return $this->id;
+    }
+
+    public function getEmbeddedDummies(): Collection
+    {
+        return $this->embeddedDummies;
+    }
+
+    public function addEmbeddedDummy(EmbeddableDummy $dummy): void
+    {
+        $this->embeddedDummies->add($dummy);
+    }
+
+    public function removeEmbeddedDummy(EmbeddableDummy $dummy): void
+    {
+        $this->embeddedDummies->removeElement($dummy);
+    }
+}