Use installed PHPUnit binary #456
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using Travis one is usefull when supporting different versions of PHP, as for example PHPUnit 5.2 is not supported on PHP 5.3 or 5.4. But in our case we don't really care and we are installing PHPUnit anyway, so we might as well use it directly instead of having to update Travis one.
|
My bad we're not requiring phpunit in our |
|
This is not currently possible due to conflicts. This is also the reason why some unit tests are marked as skipped. |
|
Which conflicts are you referring too? |
|
See #433 We need |
|
We should have an issue for it in the backlog to keep track of it then :/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using Travis one is useful when supporting different versions of PHP, as for example PHPUnit 5.2 is not supported on PHP 5.3 or 5.4. But in our case we don't really care and we are installing PHPUnit anyway, so we might as well use it directly instead of having to update Travis one.