Fix and test composite identifier collection retrieval #504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soyuka
force-pushed
the
fix-composite-identifier-collection
branch
4 times, most recently
from
fa49fa7
to
11bbc1a
Compare
|
Does someone know why composer is failing? Thought #502 would fix this :/. |
|
Nice, thank you for this contribution @soyuka! As far as I can see, it's not composer failing here but a test :) |
soyuka
force-pushed
the
fix-composite-identifier-collection
branch
from
11bbc1a
to
a751a12
Compare
|
@sroze oh my bad, must've clicked on an old travis build. It's always the context, because the resources order is not the same as it's on my computer ^^". Should be fixed on the next run, let's w8 and see \o/.
|
soyuka
force-pushed
the
fix-composite-identifier-collection
branch
2 times, most recently
from
8a7a5c6
to
518d307
Compare
soyuka
force-pushed
the
fix-composite-identifier-collection
branch
from
518d307
to
d1e01ce
Compare
|
Thank you @soyuka |
magarzon
pushed a commit
to magarzon/core
that referenced
this pull request
Feb 12, 2017
…ier-collection Fix and test composite identifier collection retrieval
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a behat test on a complex composite identifier case
Fix the collection retrieval of a resource made of composite identifiers