Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[OpenApi] Add ApiResource::openapi and deprecate openapiContext #5254

Merged
merged 6 commits into from Dec 16, 2022
Merged

[OpenApi] Add ApiResource::openapi and deprecate openapiContext #5254

merged 6 commits into from Dec 16, 2022

Conversation

vincentchalamon
Copy link
Contributor

@vincentchalamon vincentchalamon commented Dec 7, 2022 •
edited

Q A
Branch? main
Tickets #4890
License MIT
Doc PR api-platform/docs#1679

@vincentchalamon vincentchalamon self-assigned this Dec 7, 2022
@vincentchalamon vincentchalamon force-pushed the 4890-improve-context-operation-options branch 2 times, most recently from f307efd to 1122bb0 Compare December 7, 2022 10:05
@vincentchalamon vincentchalamon changed the title feat: add ApiResource::openapi and deprecate openapiContext [OpenApi] Add ApiResource::openapi and deprecate openapiContext Dec 7, 2022
@vincentchalamon vincentchalamon force-pushed the 4890-improve-context-operation-options branch from 1122bb0 to 84adc0e Compare December 7, 2022 10:13
@vincentchalamon vincentchalamon force-pushed the 4890-improve-context-operation-options branch from 84adc0e to 7ddbbef Compare December 7, 2022 13:00
@vincentchalamon vincentchalamon marked this pull request as ready for review December 7, 2022 13:09
@vincentchalamon vincentchalamon linked an issue Dec 7, 2022 that may be closed by this pull request
Improve *Context operation options #4890
Closed
@soyuka
Copy link
Member

soyuka commented Dec 10, 2022

I really like this it's awesome!

@vincentchalamon vincentchalamon force-pushed the 4890-improve-context-operation-options branch 3 times, most recently from c87af9b to b96a4bf Compare December 12, 2022 10:31
soyuka
soyuka reviewed Dec 16, 2022
View reviewed changes
src/OpenApi/Factory/OpenApiFactory.php Outdated Show resolved Hide resolved
src/OpenApi/Factory/OpenApiFactory.php Outdated Show resolved Hide resolved
@vincentchalamon vincentchalamon force-pushed the 4890-improve-context-operation-options branch from b96a4bf to b859906 Compare December 16, 2022 11:25
soyuka
soyuka reviewed Dec 16, 2022
View reviewed changes
phpstan.neon.dist Outdated Show resolved Hide resolved
@vincentchalamon vincentchalamon force-pushed the 4890-improve-context-operation-options branch from 9dfa88f to b2ec54b Compare December 16, 2022 12:34
@soyuka soyuka merged commit c145ec7 into api-platform:main Dec 16, 2022
@soyuka
Copy link
Member

soyuka commented Dec 16, 2022

huge thanks!

@vincentchalamon vincentchalamon deleted the 4890-improve-context-operation-options branch December 16, 2022 12:38
@jojomi
Copy link

jojomi commented Jan 30, 2023

I highly welcome this update!

Is there any way to update the code (semi-)automatically? Some Rector task or anything else?

@dannyvw dannyvw mentioned this pull request Feb 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soyuka soyuka soyuka left review comments

Assignees

@vincentchalamon vincentchalamon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve *Context operation options
3 participants
@vincentchalamon @soyuka @jojomi