Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PayloadArgumentResolver::resolve return type #5327

Merged
merged 1 commit into from
Jan 12, 2023
Merged

Fix PayloadArgumentResolver::resolve return type #5327

merged 1 commit into from
Jan 12, 2023

Conversation

MatTheCat
Copy link
Contributor

Q A
Branch? 2.7
Tickets N/A
License MIT
Doc PR N/A

ArgumentValueResolverInterface::resolve return type always have been iterable.

There is no need to make it more specific, especially because we support PHP ≥ 7.1 and full covariance support was added with PHP 7.4.

@MatTheCat MatTheCat changed the title Avoid unneeded use of covariance to keep compatibility with PHP < 7.4 Fix PayloadArgumentResolver::resolve return type Jan 12, 2023
@soyuka soyuka merged commit 444f339 into api-platform:2.7 Jan 12, 2023
@soyuka
Copy link
Member

soyuka commented Jan 12, 2023

thanks @MatTheCat !

@MatTheCat MatTheCat deleted the payload-argument-resolver-resolve branch January 12, 2023 10:01
soyuka added a commit that referenced this pull request Jan 14, 2023
* chore: switch from deprecated “loose” email validation mode to “html5” (#5326)

* chore: replace `Request::getContentType` with `Request::getContentTypeFormat` if available (#5325)

* fix: Set twig.exception_listener as service parent (#5059)

* fix(symfony): remove dependency on potentially inexistant `exception_listener` service

* define argument keys on service redefinition

* fix: avoid unneeded use of covariance to keep compatibility with PHP < 7.4 (#5327)

* fix(symfony): http cache wrong metadata argument

* chore: changelog 2.7.6

Co-authored-by: Mathieu <mathieu.lechat@les-tilleuls.coop>
Co-authored-by: Paul Andrieux <paul@appventus.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants