Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(metadata): metadata common abstract class #5364

Merged
merged 1 commit into from
Jan 26, 2023

Conversation

Byidi
Copy link
Contributor

@Byidi Byidi commented Jan 24, 2023

Q A
Branch? 3.1
Tickets #5322
License MIT
Doc PR no
  • Abstract class above ApiResource, ApiProperty and Operation
  • Operation class contains properties which must only be on GetCollection (e.g.: pagination, filters)

@Byidi Byidi force-pushed the chore/metadata branch 2 times, most recently from 113479e to a50bec5 Compare January 24, 2023 15:13
src/Metadata/ApiResource.php Outdated Show resolved Hide resolved
src/Metadata/WithResourceTrait.php Outdated Show resolved Hide resolved
src/Metadata/WithResourceTrait.php Outdated Show resolved Hide resolved
@Byidi Byidi changed the title chore(metadata): common properties refacto refactor(metadata): metadata common abstract class Jan 24, 2023
@Byidi Byidi force-pushed the chore/metadata branch 4 times, most recently from 674ad39 to bc9521a Compare January 25, 2023 09:08
@soyuka soyuka changed the base branch from 3.1 to main January 26, 2023 07:54
@soyuka soyuka changed the base branch from main to 3.1 January 26, 2023 07:54
@Byidi Byidi changed the base branch from 3.1 to main January 26, 2023 08:12
@soyuka soyuka merged commit 1b7acfa into api-platform:main Jan 26, 2023
@soyuka
Copy link
Member

soyuka commented Jan 26, 2023

Thanks @Byidi !

syl20b pushed a commit to syl20b/api-platform-core that referenced this pull request Feb 8, 2023
soyuka pushed a commit to fraynaud1330/api-platform-core that referenced this pull request Feb 28, 2023
soyuka pushed a commit to mrossard/core that referenced this pull request Apr 14, 2023
Deuchnord pushed a commit to Deuchnord/api-platform-core that referenced this pull request Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants