fix(serializer) Restore the use of placeholders named differently than id

[Aerendir]

Q	A
Branch?	3.x
Tickets	Closes #5736
License	MIT

Restore the use of placeholders named differently than id.

See #5736 for more details.

• Verify why ItemNormalizerTest::testDenormalizeGuessingUriVariables() din't intercepted the breaking change introduced with fix(serializer): put replaces embed collection #5604 (I need help here, please)

[soyuka]

We need to handle this differently, it should just find the correct ids no? I'll try to find out the issue...

[Aerendir]

Yes, it should find the correct placeholder, given the resource. But as of what I saw, the array is flat, so, if you have two placeholders with the same name, then the one overwrites the other.

This would happen even if the placeholder were named, for example, resource_id.

But, with this change, if it is named resource_id, the code may break; if it is named id, the code will handle the situation.

I agree that a cleaner solution should be found, but I currently cannot find one: I hope you will as you know the code better than me 💪

Maybe in the mean time this PR may be published and a new patch release issued, just to don't break existing apps that rely on ApiPlatform?

[soyuka]

https://github.com/api-platform/core/pull/5743/files#r1291349976