Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GraphQL: Support Enum collections #5955

Merged
merged 1 commit into from
Nov 24, 2023
Merged

Conversation

jotwea
Copy link
Contributor

@jotwea jotwea commented Nov 8, 2023

Q A
Branch? main
Tickets -
License MIT
Doc PR -

We have a resource with an array property. The content of this array are enum values. This information can be provided with a doc block. Unfortunatelly on the GraphQL API this was visible as an iterable. With the changes in this PR it will be a proper "array of enum", same like i.e. "array of string".

The Behat tests should give you an insight into the details.

Copy link
Member

@soyuka soyuka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, could you rebase against main though it looks like there's a commit that doesn't belong to this patch. Commit should be: feat(graphql): ...

@jotwea jotwea force-pushed the enum-collection branch 2 times, most recently from 23c2cf2 to c971810 Compare November 23, 2023 13:19
@soyuka soyuka merged commit 9083765 into api-platform:main Nov 24, 2023
38 of 41 checks passed
@soyuka
Copy link
Member

soyuka commented Nov 24, 2023

nice thanks@jotwea!

@jotwea jotwea deleted the enum-collection branch December 16, 2023 14:56
soyuka pushed a commit to anoziere/core that referenced this pull request Dec 18, 2023
Co-authored-by: josef.wagner <josef.wagner@hf-solutions.co>
priyadi pushed a commit to priyadi/core that referenced this pull request Jan 3, 2024
Co-authored-by: josef.wagner <josef.wagner@hf-solutions.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants