fix(hydra): remove dependency from ApiPlatform/Api dependency #6154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soyuka
reviewed
Feb 12, 2024
soyuka
reviewed
Feb 12, 2024
| /** | ||
| * Gets a filter with a backward compatibility. | ||
| */ | ||
| private function getFilter(string $filterId): FilterInterface|null |
There was a problem hiding this comment.
it's fine to keep this here imo we don't need the trait
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR purpose is to resolve issue with the splitted version.
ApiPlatform/Apiis not exported in any components, theFilterLocatorTraitcannot be loaded.This is a quick & dirty workaround that solves the 3.3.0-alpha.1 issue but I think we must find abetter way to solve and provide the filters.
We could describle a FilterRegistryInterface in
ApiPlatform/Metadataand inject it in the variouscomponents that relies on this feature (Hydra, ParameterValidator) the symfony component could fill an implementation of this registry and inject it.