fix(symfony)!: context stamp not serializable because of request object #6323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: unset request object from context array passed to the context stamp
MariusJam
force-pushed
the
fix/unserializable-context-stamp
branch
from
1626a04
to
8e91e79
Compare
soyuka
approved these changes
Apr 17, 2024
|
thanks @MariusJam ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #6302, here is the PR to completely remove request object from
$contextin theContextStamp. Symfony does not guarantee that the Request object is serializable.As specified in the commit description, this is a breaking change.