Refactor the management of operations by the swagger DocumentationNormalizer #648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuilhemN
changed the title
GuilhemN
changed the title
GuilhemN
changed the title
|
The latest commit made the |
Closed
| @@ -44,7 +44,7 @@ | |||
| private $operationMethodResolver; | |||
| private $iriConverter; | |||
|
|
|||
| public function __construct(ResourceNameCollectionFactoryInterface $resourceNameCollectionFactory, ResourceMetadataFactoryInterface $resourceMetadataFactory, PropertyNameCollectionFactoryInterface $propertyNameCollectionFactory, PropertyMetadataFactoryInterface $propertyMetadataFactory, ResourceClassResolverInterface $resourceClassResolver, OperationMethodResolverInterface $operationMethodResolver, IriConverterInterface $iriConverter) | |||
| public function __construct(ResourceNameCollectionFactoryInterface $resourceNameCollectionFactory, ResourceMetadataFactoryInterface $resourceMetadataFactory, PropertyNameCollectionFactoryInterface $propertyNameCollectionFactory, PropertyMetadataFactoryInterface $propertyMetadataFactory, ResourceClassResolverInterface $resourceClassResolver, OperationMethodResolverInterface $operationMethodResolver, IriConverterInterface $iriConverter = null) | |||
There was a problem hiding this comment.
It is not needed in case there are only custom operations (which should be the case when used as a component).
|
👍 Do you consider this PR ready to be merged @Ener-Getick? |
|
@dunglas yes, it looks good to me :) |
|
Thanks @Ener-Getick |
|
@Simperfit no more unwanted operation with this PR 👍 |
magarzon
pushed a commit
to magarzon/core
that referenced
this pull request
Feb 12, 2017
Refactor the management of operations by the swagger DocumentationNormalizer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial post:
In fact I do not even understand why some operations are treated as
customso this PR simplify theDocumentationNormalizerby removing this notion and threat all operations at once.