Fix nullable property on denormalization #703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 (when the CI will be green). Good catch @soyuka |
|
How is it that appveyor takes ~3 min whereas travis takes ~20 min? |
|
Code coverage computation... But only one build is slow. The the other one take a few minutes. |
|
still 7 min for the lowest test (without coverage) on my PR vs ~3 min on app veyor, weird. Dunno if scrutinizer is blocked right now. |
|
I just pushed a commit to optimize the build when running in non-coverage mode: 056a63f The Travis build also check Swagger compliance (it requires downloading some NPM packages), the AppVeyor build doesn't do that. |
|
Thanks you very much for discovering and fixing this bug @soyuka! |
magarzon
pushed a commit
to magarzon/core
that referenced
this pull request
Feb 12, 2017
Fix nullable property on denormalization
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug introduced in e58bd73