Add "Vary: Accept" response header #718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teohhanhui
force-pushed
the
add-vary-accept-header
branch
from
db8f3d5
to
0a1d9a3
Compare
|
Good catch, thanks Teoh! |
magarzon
pushed a commit
to magarzon/core
that referenced
this pull request
Feb 12, 2017
…eader Add "Vary: Accept" response header
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We must add the "Vary: Accept" response header, since we're varying the response by "Accept" request header. Otherwise, it messes up HTTP caching (Varnish etc.).