Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] Typo in SerializerContextBuilderInterface::createFromRequest #766

Closed
wants to merge 1 commit into from
Closed

Conversation

benjaminrau
Copy link

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets na
License MIT
Doc PR dunglas/doc#10

Please update this template with something that matches your PR

To me it seems that this method declaration is not correct, at least ive never seen that and my PHPStorm complains about it.

To me it seems that this method declaration is not correct, at least ive never seen that and my PHPStorm complains about it.
@Simperfit
Copy link
Contributor

Did you understand that this is php7 typehint ?

@benjaminrau
Copy link
Author

@Simperfit As you can read from my comment, no. Going to close PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants