Pass ResourceMetadata instead of $resourceShortName in OperationPathR… #790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amenophis
force-pushed
the
allow-global-config
branch
3 times, most recently
from
f136fbd
to
5143904
Compare
amenophis
force-pushed
the
allow-global-config
branch
from
5143904
to
3a9248d
Compare
This was referenced Oct 7, 2016
dunglas
approved these changes
Oct 7, 2016
Shine-neko
approved these changes
Oct 7, 2016
Shine-neko
approved these changes
Oct 7, 2016
teohhanhui
suggested changes
Oct 7, 2016
There was a problem hiding this comment.
This is not a good way to do it. We should only provide string $resourceClass. Then you can get the ResourceMetadata yourself.
/cc @dunglas
|
@teohhanhui What is the problem ? The ResourceMetadata is already loaded, why not allow to pass it directly ? |
|
@amenophis "Already loaded" is merely an implementation detail. We make the interface harder to implement and use if we pass the |
|
Can we close this one? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass ResourceMetadata instead of $resourceShortName in OperationPathResolvers