Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(kubernetes) : Adding instruction for the messenger queue with Fr… #1939

Merged
merged 5 commits into from
Apr 29, 2024

Conversation

matthieu-delisle
Copy link
Contributor

FrankenPHP image Kubernetes instruction incomplete

The readinessProbe and livenessProbe suggested in the documentation failed because the /bin/ps wasn't installed on the Docker Image.

…ankenPHP image

The readinessProbe and livenessProbe suggested in the documentation failed because the /bin/ps wasn't installed on the Docker Image.
Copy link
Member

@dunglas dunglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

deployment/kubernetes.md Outdated Show resolved Hide resolved
matthieu-delisle and others added 2 commits April 24, 2024 09:15
Co-authored-by: Kévin Dunglas <kevin@dunglas.fr>
@matthieu-delisle
Copy link
Contributor Author

I just removed a ")" in your suggestion, I think everything is ok now.

@dunglas dunglas merged commit e3a1488 into api-platform:3.2 Apr 29, 2024
1 check passed
@dunglas
Copy link
Member

dunglas commented Apr 29, 2024

Thank you very much @matthieu-delisle

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants