Contract tests

[bbenligiray]

Set up Jest and wrote an example test (only JS for now). I have some noob questions. Also recommend improvements where you see them.

Does jest (or ts-jest) automatically build the tests for us in the background at the start of each test?

I'm getting

(node:10702) V8: /home/burak/git/airnode/packages/contracts/node_modules/ganache-core/node_modules/rustbn.js/lib/index.asm.js:2 Linking failure in asm.js: Unexpected stdlib member

when I run the test but everything seems to work fine. Is this error familiar to you?

[andreogle]

I'm not sure what you mean by "build the tests in the background", sorry. Build what exactly? There is also a really helpful --watch flag that watches for file changes and then re-runs tests for you. I use this a lot when writing tests. See the scripts in oracle-monitor's package.json for some examples I've used.

I'm not sure about that error either unfortunately. I guess if it's not causing anything to break, then it's probably fine to ignore. It looks like it could be related to many things and is hard to pinpoint. Things like your Node version, the Solidity version, your environment etc. I'll try hop onto this branch shortly and see if I get the same.

[andreogle]

I think we'll probably want to extract common dependencies to the root package.json to avoid having to maintain duplicate entries. That would mean most of the deps here would be moved up. Only things like ganache-core would remain.

It may even make sense to just move all dependencies to the root package.json. I'm not sure yet

[bbenligiray]

extract common dependencies to the root package.json

That sounds good if it's not going to mess with Serverless.

It may even make sense to just move all dependencies to the root package.json

This may cause unused dependencies to float around because it's difficult to tell if they are being used in one of the leaf packages

[andreogle]

I don't think it should mess with serverless, but we'll have to see. lerna is still new to me.

Ok let's keep specific dependencies in the package's package.json

[andreogle]

I think we should add linting and static analysis tools for our solidity contracts.

I know that Chainlink uses solhint. Here is a list I found from a quick google search that looks quite good. I have no idea which tools are still maintained though. They are probably even more tools out there
https://consensys.github.io/smart-contract-best-practices/security_tools/

[andreogle]

I like to put these kinds of tools on the strictest settings and then disable rules I don't like/agree with as needed. This is just my preference though and I know that quite a lot of people get annoyed by having lots of linting errors getting in their way lol.

[bbenligiray]

You're right, I'll set that up

[andreogle]

Some of these tools look really good.

https://github.com/trailofbits/manticore
https://github.com/crytic/slither
https://github.com/crytic/echidna
https://github.com/ConsenSys/mythril
https://github.com/melonproject/oyente
https://github.com/pventuzelo/octopus

I imagine that there's a lot of overlap between them but I guess that running a few couldn't hurt? I'm especially a fan of fuzz testing tools

[bbenligiray]

I'm not sure what you mean by "build the tests in the background", sorry. Build what exactly?

I mean the tests are written in TS, but they have no tsconfig, are not built explicitly and built files are not around. That was a bit confusing to me. I'll check out the stuff you've mentioned and come back.

[andreogle]

I guess that ts-jest just doesn't output any files since it doesn't really need to. I'm not sure of the details though

[andreogle]

I get the same error when running the tests 🤷‍♂️

V8: /home/andre/Development/airnode/packages/contracts/node_modules/ganache-core/node_modules/rustbn.js/lib/index.asm.js:2 Linking failure in asm.js: Unexpected stdlib member