Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: run the test case #16

Open
membphis opened this issue Nov 25, 2020 · 10 comments · May be fixed by #27
Open

ci: run the test case #16

membphis opened this issue Nov 25, 2020 · 10 comments · May be fixed by #27
Labels
enhancement New feature or request

Comments

@membphis
Copy link

No description provided.

@membphis membphis added the enhancement New feature or request label Dec 28, 2020
@membphis
Copy link
Author

we need to do this asap

@membphis
Copy link
Author

@nic-chen

@nic-chen
Copy link
Collaborator

@membphis @tokers @spacewander
I wrote a simple version, but gave up.
We need to choose a test framework. I plan to use ginkgo for it as well. What do you think?

@membphis
Copy link
Author

ginkgo

seems a better way

@spacewander
Copy link

I prefer to write one with py.test...
It would be more simple to write python code.

@spacewander
Copy link

There is some limitation with a test framework written in Go, for example:
Go doesn't support HTTP 1.0 while envoy supports it.

@membphis
Copy link
Author

I prefer to use Go.

In CNCF, Go is more popular.

@nic-chen
Copy link
Collaborator

Yes, it is easier to use Python. The only problem is that there will be one more language, and Go is used in several projects in the APISIX community, .

@spacewander
Copy link

I wrote a test framework with Go before.
It is not a good idea to choose a static language. It's not so efficient to satisfy the target. And there is some issues with Go itself, for example, no HTTP 1.0 support.

BTW, we already use perl/shell/Makefile code in the APISIX.

@membphis
Copy link
Author

for example, no HTTP 1.0 support.

If we need to test it, we can use the TCP way for some simple cases. I think this is fine.

BTW, we already use perl/shell/Makefile code in the APISIX.

If possible, I want to avoid using "perl" :(

BTW, I found another open-source gateway project gloo, Test cases are written in Golang: https://github.com/solo-io/gloo/tree/master/test/e2e

@nic-chen nic-chen linked a pull request Jan 13, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants