Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing propTypes in all React components #24

Closed
XVincentX opened this issue Sep 8, 2015 · 4 comments
Closed

Missing propTypes in all React components #24

XVincentX opened this issue Sep 8, 2015 · 4 comments
Labels
Type: Enhancement

Comments

@XVincentX
Copy link
Contributor

This does not let us use its builtin validation (and furthermore, is throwing a lot of warnings)
@Baggz
Copy link
Contributor

Baggz commented Sep 10, 2015

Good catch, @XVincentX!

@Baggz
Copy link
Contributor

Baggz commented Sep 21, 2015

@XVincentX

I have added propTypes to most of the components... Is this still valid?

@Baggz
Copy link
Contributor

Baggz commented Sep 21, 2015

Closing.

Feel free to reopen if you feel it's still valid.

@Baggz Baggz closed this as completed Sep 21, 2015
@XVincentX
Copy link
Contributor Author

It is. However, I still can see some validation errors, so perhaps we're missing some cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Baggz @XVincentX