Skip to content
This repository has been archived by the owner on Apr 4, 2019. It is now read-only.

doc: add description for using python2 with python3 #153

Merged
merged 1 commit into from
Mar 2, 2018

Conversation

abtris
Copy link
Contributor

@abtris abtris commented Feb 27, 2018

No description provided.

README.md Outdated
@@ -28,6 +28,10 @@ paver test
If you ran `bb init` and you want to do "discovery testing" with the integration tests,
set `FORCE_DISCOVERY`environment variable to `1`.

### Troubleshooting

`./venv/bin/paver` - use if paver in python3 is prefered before python2 (you need them for paver)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand the sentence and I can't suggest different wording, because I don't know paver 😞

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

paver that tool in readme everywhere?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know what paver is, but I don't know what you meant. And I can't decipher it and reformulate the sentence, because I don't remember how Paver works.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, refactored

@abtris abtris force-pushed the abtris/python3-release-python2 branch from 95fafb5 to 7343ac4 Compare February 27, 2018 15:20
@abtris
Copy link
Contributor Author

abtris commented Mar 1, 2018

@honzajavorek can you make re-review

honzajavorek
honzajavorek previously approved these changes Mar 1, 2018
Copy link
Contributor

@honzajavorek honzajavorek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now I understand it perfectly. Thanks!

README.md Outdated
@@ -28,6 +28,10 @@ paver test
If you ran `bb init` and you want to do "discovery testing" with the integration tests,
set `FORCE_DISCOVERY`environment variable to `1`.

### Troubleshooting

If you try run `paver bump` and get error `TypeError: 'map' object is not subscriptable` you can run `./venv/bin/paver bump` for fix this.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

- for fix this
+ to fix this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@abtris abtris force-pushed the abtris/python3-release-python2 branch 2 times, most recently from 361209c to 3c8c7fb Compare March 1, 2018 15:24
@honzajavorek honzajavorek merged commit adf648b into master Mar 2, 2018
@honzajavorek honzajavorek deleted the abtris/python3-release-python2 branch March 2, 2018 10:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants