Skip to content
This repository has been archived by the owner on Apr 4, 2019. It is now read-only.

feat(dep): add scoped package support #174

Merged
merged 2 commits into from
Aug 16, 2018

Conversation

opichals
Copy link
Contributor

No description provided.

honzajavorek
honzajavorek previously approved these changes Aug 16, 2018
Copy link
Contributor

@honzajavorek honzajavorek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please check whether this closes #160? Thanks!

return (split_result[0], 'latest')
else:
try:
return ('@'+split_result[1], split_result[2])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style nitpick:

- '@'+split_result[1]
+ '@' + split_result[1]

try:
return ('@'+split_result[1], split_result[2])
except IndexError:
return ('@'+split_result[1], 'latest')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dtto

@opichals opichals force-pushed the opichals/add-scoped-package-support branch from ba21139 to 74c8652 Compare August 16, 2018 11:29
@opichals opichals merged commit 820e69e into master Aug 16, 2018
@honzajavorek honzajavorek deleted the opichals/add-scoped-package-support branch August 16, 2018 12:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants