Allowing default values for required parameters #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
netmilk
force-pushed
the
netmilk/default-example-error
branch
from
87b5f53
to
5df3db0
Compare
| result.errors.push(text) | ||
| if param.required is true and | ||
| (param.example is '' or param.example is undefined or param.example is null) and | ||
| (param.default is '' or param.default is undefined or param.default is null) |
There was a problem hiding this comment.
why not just if param.required and not param.example and not param.default? are there any corner cases?
honzajavorek
force-pushed
the
netmilk/default-example-error
branch
from
d2b372c
to
f4d1671
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.