Fix an error thrown with Swagger using auth and multi responses #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Many thanks to @hugecannon who sent us an example of a failing Swagger document in apiaryio/dredd#870
honzajavorek
force-pushed
the
honzajavorek/update-swagger-fury-adapter
branch
from
0409aa6
to
e163d7a
Compare
michalholasek
approved these changes
Aug 23, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a failing test based on the #93 and apiaryio/dredd#870 bug reports and fixes the test by upgrading the Swagger adapter. Closes #93.
I thought I'll use one of the fixtures provided by the
swagger-zoopackage, but I couldn't find a suitable one there, so at the end I've used minimal failing document based on the bug report in apiaryio/dredd#870. I've left theswagger-zoopackage updated though, because it's nothing bad to have this dependency up to date.