Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Gavel validators (non-breaking) #150

Open
2 tasks done
artem-zakharchenko opened this issue May 6, 2019 · 2 comments
Open
2 tasks done

Refactor Gavel validators (non-breaking) #150

artem-zakharchenko opened this issue May 6, 2019 · 2 comments

Comments

@artem-zakharchenko
Copy link
Contributor

artem-zakharchenko commented May 6, 2019

Gavel internals can be refactored, preserving the same public API.

Why

  • To have a more readable code
  • To have less code
  • To remove classes and mutations

Roadmap

@artem-zakharchenko artem-zakharchenko self-assigned this May 9, 2019
@artem-zakharchenko artem-zakharchenko removed their assignment May 29, 2019
@artem-zakharchenko artem-zakharchenko changed the title Refactor Gavel internals (non-breaking) Refactor Gavel validators (non-breaking) Jul 3, 2019
@artem-zakharchenko
Copy link
Contributor Author

Removing the milestone because the remaining changes are not breaking, and are entirely internal.

@artem-zakharchenko
Copy link
Contributor Author

Gavel validators partially refactored during #90. Now all validators are constructed with only expected data, and any actual data is accepted as an argument during the validator.validate() call.

There is still a room for improvement (i.e. obscure class extensions for HeadersExample), yet none of them are blocking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant