-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds ESLint #152
Adds ESLint #152
Conversation
package.json
Outdated
@@ -10,6 +10,7 @@ | |||
"gavel": "bin/gavel" | |||
}, | |||
"scripts": { | |||
"lint": "eslint lib/**/*.js", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not linting tests?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point. Added under 837df08.
I want to also add some linting in a watch mode, since the library doesn't have a compilation step, I'd like to prevent finding out about linting errors in CI. Needs to fail fast on local, while developing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
ce18cb2
to
7505107
Compare
{ | ||
"useTabs": false, | ||
"semi": true, | ||
"trailingComma": "none", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do value trailing comma for git blame purposes, and I think it's also how Dredd is set up.
However, I've stumbled into issues when trailing commas in commonJS fail execution of a module in NodeJS.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dredd is set up to have trailing commas in objects/arrays, but not in functions. It was because of Node 6 support. Is is possible that the issues you've experienced were because of having trailing commas in function arguments and executing with Node 6?
https://github.com/apiaryio/dredd/blob/master/.eslintrc.js#L12:L20
7505107
to
69f9a93
Compare
{ | ||
"useTabs": false, | ||
"semi": true, | ||
"trailingComma": "none", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dredd is set up to have trailing commas in objects/arrays, but not in functions. It was because of Node 6 support. Is is possible that the issues you've experienced were because of having trailing commas in function arguments and executing with Node 6?
https://github.com/apiaryio/dredd/blob/master/.eslintrc.js#L12:L20
🎉 This PR is included in version 3.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Changelog
eslint
config and npm commands (using Dredd eslint config as an example)GitHub