feat: coerces missing "body" of the actual HTTP message #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
artem-zakharchenko
commented
Jun 19, 2019
artem-zakharchenko
commented
- Closes Provide missing real body coercion #198
artem-zakharchenko
force-pushed
the
198-coerce-missing-real-body
branch
from
20aeca8
to
9b4a8fb
Compare
| // 1. Expcected '', and got '' (TextDiff/TextDiff, valid) | ||
| // 2. Expected {...}, but got '' (Json/TextDiff, invalid, produces "missing real body" error) | ||
| // 3. Expected {...}, but git "foo" (Json/TextDiff, invalid, produces types mismatch error). | ||
| if (expected.body !== '' && hasEmptyRealBody) { |
There was a problem hiding this comment.
This isn't the best solution in terms of cyclomatic complexity, but the one that works without introducing an entirely custom flow for missing body. This way we can always coerce missing actual "body" to an empty string and properly differentiate between three mentioned scenarios.
artem-zakharchenko
force-pushed
the
198-coerce-missing-real-body
branch
from
9b4a8fb
to
dc9aa42
Compare
|
🎉 This PR is included in version 6.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.