Removes unused dependencies

[artem-zakharchenko]

This pull request reviews and uninstalls unused dependencies from gavel. No breaking changes are introduced.

GitHub

• Closes Clean up dependencies #207

[artem-zakharchenko]

Dependencies analyzis

Including the insights about other dependencies that may be easy to remove.

clone

Used only at headers-json-example validator to deep copy the original result from JsonSchema and mutate it with a new message:

gavel.js/lib/validators/headers-json-example.js

Line 74 in 2eb036d

const resultCopy = clone(result, false);

caseless

Used only in tv4-to-headers-message to reference expectedHeaders headers keys in a caseless way.

gavel.js/lib/utils/tv4-to-headers-message.js

Line 14 in 2eb036d

const expected = caseless(expectedHeaders).get(headerName);

[honzajavorek]

I thought commander is used for the CLI?

gavel.js/bin/gavel

Line 4 in 0138366

var cmd = require('commander');

[honzajavorek]

Except of commander it looks good :) Thanks!

[artem-zakharchenko]

Good catch.

That's the only place I found it being used:

gavel.js/bin/gavel

Line 10 in d79a0e1

cmd.version('0.0.1');

Does it only sets a version, or are there some side-effects in place that I'm not seeing?

[honzajavorek]

Does it only sets a version, or are there some side-effects in place that I'm not seeing?

That's out of scope of my memory. We'd need to dig into the ancient scrolls in the attic to learn about that.

[artem-zakharchenko]

By examining the source code of commander, I can conclude that it's a util library to build CLI modules. It doesn't seem to do anything but setting the version of the program, as there is explicit syntax like cmd.option(), cmd.action(), etc.

I'm not familiar with commander, but we don't see to use it at the moment to its full extent. At the same time, it's an approved dependency, so, perhaps, we should keep it?

The functionality of commander looks very similar to yargs that I'm used to. I think we can build a good CLI design with commander, or at least can try to do that.

[honzajavorek]

So it looks like we don't need it 😄 But I think it is okay to keep it, not to add ourselves work. Up to you. I'm more concerned about the CI passing with non-executable Gavel CLI. I wonder if the CLI tests even run.

[artem-zakharchenko]

commander module reverted and remains the dependency of gavel module. Should be ready to be merged.

[ApiaryBot]

🎉 This PR is included in version 6.1.3 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀