Add a list of acknowledgements #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| resources = File.read('Pods/Target Support Files/Pods-Polls/Pods-Polls-resources.sh').split("\n") | ||
| rsync_index = resources.index { |line| line =~ /^rsync/ } | ||
| resources.insert(rsync_index, 'install_resource "Target Support Files/Pods-Polls/Pods-Polls-acknowledgements.plist"') | ||
| File.write('Pods/Target Support Files/Pods-Polls/Pods-Polls-resources.sh', resources.join("\n")) |
There was a problem hiding this comment.
looks brittle but I bet it works :)
There was a problem hiding this comment.
It certainly is brittle and tied to implementation details of CocoaPods, it will be replaced with a CocoaPods plugin sometime which allows this to work better: CocoaPods/CocoaPods#2465
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request changes the settings screen to include acknowledgements (the open source components it depends on) along with the applications version number.