Update tests for MSON refract #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests failing. And are we not going to port the mocha tests? |
danielgtaylor
force-pushed
the
daniel/mson-tests
branch
from
b4fed70
to
114b9de
Compare
|
@pksunkara test are (finally) passing and there are some basic MSON Refract tests included now. I removed some of the more complex tests because I don't think they belong in a binding, but rather in the upstream library (e.g. whether a mixin generates the right elements). What we really care about in the binding is that a very basic example works without errors and produces refract elements in the right place. Thoughts? |
|
|
||
| attributes = result.ast.content[0].content[0].actions[0].examples[0].responses[0].content[0] | ||
| dataStructures = result.ast.content[1].content | ||
| console.log JSON.stringify(result.ast, null, 2) |
|
One minor thing. Will merge it once it's fixed. |
This removes the old MSON AST based tests in favor of new MSON Refract ones. The tests are significantly less complex because the exact structure of the MSON result should be tested in the upstream library, not the language binding. Here we just test for a very basic structure in both the attributes and data structures sections.
danielgtaylor
force-pushed
the
daniel/mson-tests
branch
from
824f581
to
3753d4a
Compare
|
@pksunkara the extra |
pksunkara
added a commit
that referenced
this pull request
Aug 6, 2015
Update tests for MSON refract
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the currently-failing tests in the
shared/refractbranch by updating the fixture to use MSON refract and commenting out some MSON-AST specific tests that will need to be updated in the future.