Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TestsRequestHelperTrait - Inject ID and Override Endpoint not working together #180

Closed
twcarefoot opened this issue Jun 23, 2017 · 0 comments

Comments

@twcarefoot
Copy link

Injecting an ID doesn't work with the endpoint override since injected ids only utilizes the TestsRequestHelperTrait property $endpoint. This means the $overrideEndpoint can never be injected with an id.

https://github.com/apiato/apiato/blob/master/app/Ship/Tests/PhpUnit/TestsRequestHelperTrait.php#L169

My main question is wondering if this desired functionality?

This is the example from the docs
$response = $this->endpoint('get@item/{id}')->injectId($user->id)->makeCall();

That doesn't work so I am just going to use the functionality like this:
$response = $this->endpoint('get@item/' . $user->id)->makeCall();

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants