Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[master] Add API_PREFIX env variable #412

Merged
merged 1 commit into from Apr 30, 2018

Conversation

amaelftah
Copy link
Member

Description

this PR , adds API_PREFIX env variable

Motivation and Context

at some cases the API_URL will be the same as APP_URL on different environments , so by this env variable we can change the prefix between different environments

Types of changes

  • [] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • [] My code follows the code style and structure of this project.
  • [] I have updated the documentation accordingly.

@johannesschobel johannesschobel merged commit 12acd0f into apiato:master Apr 30, 2018
@johannesschobel
Copy link
Contributor

sorry it took me so long 😆 i was quite busy and partially on vacation ;)

@ghost
Copy link

ghost commented Oct 10, 2018

Wait, I have a question. Aside from making this .env variable by itself, what is the purpose of having the prefix? Where is it used in the Ship code?

@ghost
Copy link

ghost commented Oct 10, 2018

Ah, now I can see this was used inside the apiato/core package. 👍

@johannesschobel
Copy link
Contributor

its in the core...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants