Remove support for 'apidoc' field in spec #895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
mbryzek
commented
Oct 20, 2022
mbryzek
commented
- wip
- Remove apidoc
- wip
- Remove support for 'apidoc' field in spec
- never implemented - auto upgrade api json files
benwaffle
reviewed
Oct 20, 2022
| */ | ||
| object RemoveApiDocElement extends Upgrader { | ||
| def apply(js: JsObject): JsObject = { | ||
| js - "apidoc" |
There was a problem hiding this comment.
why remove this field in code? why not reject the upload?
There was a problem hiding this comment.
experimenting with auto upgrade for a change to interfaces... feels annoying to require developers to change their spec (don't want to introduce a breaking change here for devs)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.