Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix validation around types and interfaces #900

Merged
merged 1 commit into from
Nov 16, 2022
Merged

Fix validation around types and interfaces #900

merged 1 commit into from
Nov 16, 2022

Conversation

mbryzek
Copy link
Collaborator

@mbryzek mbryzek commented Nov 16, 2022

  • code generators currently expect types to be concrete types (not interfaces)
  • this PR validates that certain types must not be interfaces where not expected
  • in future, can re-evaluate this constraint to see if we should be allowing
    interfaces here

@mbryzek
Fix validation around types and interfaces
3fad85d 
  - code generators currently expect types to be concrete types (not interfaces)
  - this PR validates that certain types must not be interfaces where not expected
  - in future, can re-evaluate this constraint to see if we should be allowing
    interfaces here
@mbryzek mbryzek merged commit 9f7818f into main Nov 16, 2022
@mbryzek mbryzek deleted the types branch November 16, 2022 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@mbryzek