-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix error with parenthesis in apiGroup (#994) #1022
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello, thanks a lot, that's the kind of PR I like to see ;)
Would be great if you could also add a test for this. It should probably be similar to test/core/worker_api_use_test.js
. But the core lib and their test I didn't touch much during the rewrite, so it's still "old school" let's say.
example/example.js
Outdated
@@ -151,3 +151,23 @@ function thankUser() { return; } | |||
* @apiBody {String} name=Paris Name of the city | |||
*/ | |||
function createCity() { return; } | |||
|
|||
/** | |||
* @api {get} /catagory Get a category |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo on catagory
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
@NicolasCARPi Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Great, thanks!
While you're at it, I'd really like #984 to be adressed. sampleRequestOff doesn't work and I couldn't figure out why... It would make the demo page better by removing it where it's not necessary. |
@NicolasCARPi I am currently on #938 but I will have a look at #984. |
Ok cool :) |
No description provided.