Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix styling issue with booleans (#1077) #1079

Merged
merged 4 commits into from
Nov 21, 2021
Merged

Fix styling issue with booleans (#1077) #1079

merged 4 commits into from
Nov 21, 2021

Conversation

esaracco
Copy link
Contributor

@esaracco esaracco commented Nov 1, 2021

No description provided.

@esaracco
Copy link
Contributor Author

esaracco commented Nov 8, 2021

@NicolasCARPi I think I'm done with this PR too. Tell me if you see anything to fix.

@@ -421,16 +421,17 @@ <h3>{{__ "Parameters"}}</h3>
</div>
<input class="invisible">
{{else}}
<div class="input-group-addon">{{{type}}}</div>
<div class="sample-request-input-{{type}}-container"><div>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is there an empty div here?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nevermind I see why now.

Copy link
Collaborator

@NicolasCARPi NicolasCARPi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a big fan of the added empty div nor the added css but I'll merge nonetheless as it improves existing state.

@NicolasCARPi NicolasCARPi merged commit d77e28a into apidoc:dev Nov 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants