This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
Fix bug where name in package.json apidoc property is overridden. #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saitheexplorer
commented
Dec 2, 2014
saitheexplorer
commented
- Move name, version, description getters to after parsing package.json.
- Fixes Name field in package.json overrides package.json apidoc object. #169.
Add dependency check.
|
Tried running the tests locally, the only things that look different between the fixture file and the temp file is the timestamp and the version number in the fixtures file (still 0.8.2) |
|
Thank you, added in 0.9.1 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.