This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
Sample requests should also support basic GET requests with standard que... #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 |
1 similar comment
|
+1 |
|
👍 |
|
BTW +1 |
|
+1 |
|
I'll add that we integrated this pull request into our local copy of this repo and it has mostly worked with a few modifications. |
|
👍 Hoping this feature makes it in. |
|
@rottmann is there any chance to see this one merged please ? |
|
+1 |
|
Thanks, added in 0.14.0 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...ry parameters
Right now when doing sample requests with basic GET endpoints JSON stringified params are being appended to the end of the url rather than added as standard query params. For example, when sending a sample request with sample data like var1 = 123 & var2 = 456 you get something like example.com/?{%22var1%22:%22123%22,%var2%22:%2245%22} instead of example.com/?var1=123&var2=456.